feat(world,store): add initialize method, initialize core tables in core module #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 59796f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
reviewed
Sep 13, 2023
| @@ -50,6 +51,7 @@ contract CoreModule is Module { | |||
| } | |||
|
|
|||
| function installRoot(bytes memory) public override { | |||
| StoreCore.registerCoreTables(); | |||
There was a problem hiding this comment.
wondering if this should be in _registerCoreTables
holic
reviewed
Sep 13, 2023
.changeset/tricky-beds-kiss.md
Outdated
| --- | ||
| "@latticexyz/cli": patch | ||
| "@latticexyz/store": patch | ||
| "@latticexyz/world": patch |
There was a problem hiding this comment.
should we add another changeset for #1385?
There was a problem hiding this comment.
ohh true forgot it there. Could do that in a separate followup though, this PR doesn't actually use the WorldFactory yet (because calling initialize in a separate transaction is supported it's not strictly necessary.)
holic
previously approved these changes
Sep 13, 2023
alvrs
commented
Sep 13, 2023
.changeset/tricky-beds-kiss.md
Outdated
Comment on lines
15
to
17
|
|
||
| - The `StoreRead` contract no longer calls `StoreCore.initialize` in its constructor. | ||
| `StoreCore` consumers are expected to call `StoreCore.initialize` and `StoreCore.registerCoreTable` in their own setup logic. |
There was a problem hiding this comment.
Suggested change
| - The `StoreRead` contract no longer calls `StoreCore.initialize` in its constructor. | |
| `StoreCore` consumers are expected to call `StoreCore.initialize` and `StoreCore.registerCoreTable` in their own setup logic. |
moving this to its own changeset bc it's the only major change
holic
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purpose is to save a lot of bytecode in the
WorldandWorldFacorycontracts